Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Blade and Laravel support for netbeans #7531

Open
haidubogdan opened this issue Jun 29, 2024 · 5 comments
Open

PHP Blade and Laravel support for netbeans #7531

haidubogdan opened this issue Jun 29, 2024 · 5 comments
Labels
kind:feature A feature request PHP [ci] enable extra PHP tests (php/php.editor)

Comments

@haidubogdan
Copy link

haidubogdan commented Jun 29, 2024

Description

Blade and Laravel support for netbeans

Laravel framework with blade templating are very popular, so it makes sense to include them in the Netbeans IDE - PHP.
I worked on a personal blade plugin for netbeans on https://github.com/haidubogdan/netbeans-php-blade-plugin.
By adding this plugin in the netbeans repository the following features will be added :

  • syntax coloring
  • declaration finder for yield, includes
  • completion helper for directives
  • template usage

There is also a work in progress plugin for laravel framework https://github.com/haidubogdan/netbeans-php-laravel-framework
It will include utility tools like :

  • php CLI using docker or remote VM connection
  • declaration finder for config and views inside the code repository
  • completion for views and config paths

Use case/motivation

The main goal is to help the development process of PHP projects done in laravel.
I will assume the main development process.

Related issues

No response

Are you willing to submit a pull request?

Yes

@haidubogdan haidubogdan added kind:feature A feature request needs:triage Requires attention from one of the committers labels Jun 29, 2024
@troizet troizet added the PHP [ci] enable extra PHP tests (php/php.editor) label Jun 29, 2024
@matthiasblaesing matthiasblaesing removed the needs:triage Requires attention from one of the committers label Jul 3, 2024
@matthiasblaesing
Copy link
Contributor

Not sure what is the intention of this issue. There is no need for an issue to get things into NetBeans. The normal process is to prepare a PR for the feature you want to implement, get it reviewed (might involve multiple cycles) and then get a committer to actually merge it to master.

It helps (from my perspective) if the PR is focused and changes things incrementally. I.e. finding someone to review a PR that changes the whole way PHP is handled in the IDE will be impossible, finding someone, who reviews a PR, that fixes a specific issue and validates that with tests is much more likely.

From my perspective the two primary contacts for PHP development in the IDE are @junichi11 and @tmysik and it would be good if they could chime in.

@tmysik
Copy link
Member

tmysik commented Jul 3, 2024

Totally agree with @matthiasblaesing, creating a PR (or perhaps better, more smaller PRs, if possible?) would be great. Definitely ask for review from @junichi11, I can try to help too.

Thank you.

@haidubogdan
Copy link
Author

Ok,
I will keep this issue opened to have a backtracking of this proposed evolution.
So a simple Fork and PR should be enough then ?

@matthiasblaesing
Copy link
Contributor

@haidubogdan the general answer is:

  1. You create a personal fork of the NetBeans repository
  2. You create a new branch from current master to work on your feature
  3. You create a PR from that branch

If your changes can be integrated independently, steps 2+3 can be done multiple times in parallel. If they build on top of each other, you can create new branches based on the PR branch for next step. However you should be prepared to rebase that work onto the finally reviewed PR branch. While a PR is in review there is a quite big chance, that changes will have to be done as part of that.

@mbien
Copy link
Member

mbien commented Jul 9, 2024

link to old issue: https://issues.apache.org/jira/browse/NETBEANS-503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature A feature request PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

No branches or pull requests

5 participants