Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if invalid integer cells still causes columns to be converted to floating point #72

Open
rogerdahl opened this issue Jan 17, 2024 · 0 comments
Assignees
Labels
EDI Environmental Data Initiative medium priority Medium priority

Comments

@rogerdahl
Copy link
Collaborator

IEEE floating point values have an embedded NaN representation. That is, there is a bit pattern for NaN. However, plain integers do not have an NaN representation (all available bit patterns are assigned to valid integers). Pandas deals with this by converting integer columns to floating point columns if any of the cells in the column do not contain valid integers, and then using the floating point NaN representation for those cells. A change already implemented in the integer parser in DeX may have fixed this. We'll need to set up a specific combination of EML with column declared as integer, and a table with invalid integers to check.

@rogerdahl rogerdahl added medium priority Medium priority EDI Environmental Data Initiative labels Jan 17, 2024
@rogerdahl rogerdahl self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EDI Environmental Data Initiative medium priority Medium priority
Projects
Status: ToDo
Development

No branches or pull requests

1 participant