Make it possible to customize the completing-read function #91
Conversation
|
Looks like a useful addition, thanks! I'm not familiar with completing engines, but maybe I should add to the documentation something like this: "If you change completion globally in your setup, e.g. by enabling Would that be correct? |
I haven't tested your PR, but does this mean that currently it doesn't via customize? Because that's definitely something to address. Unfortunately, this isn't really my area of expertise. |
Yes, I think that's a good way to phrase it. |
Right. It isn't usable as-is. I spent a little while on this but I wasn't able to figure it out. It's what I was trying to do in here, c6597ff#diff-2b2d30963fb9d37edc1f2ac4e23abbdab9090ef054ffdd9860fc887cf50a66efR235. From the customize interface I tried setting |
The latter is a customizable variable that defaults to `completing-read'. This makes it possible to, for example, use a special completing reader just for zetteldeft without using it universally.
0c3f322
to
3305fa3
Compare
|
@EFLS I finally tracked down and fixed the problem with customize. I rebased my branch against current I think this is ready to be tested now. I wanted to include your proposed doc change but I wasn't sure where it was supposed to go. |
|
Thanks, I'll take a look at this in a short while! |
Add a customizable variable,
zetteldeft-completing-readwhich defaults to'completing-readbut which can be replaced with compatible functions such asivy-read.A caveat: if you say
(fset 'zetteldeft-completing-read 'ivy-read)somewhere then this works exactly as I'd hoped. I can't figure out how to make it work via customize. This PR therefore isn't acceptable as-is, but I hope it's a useful start.ref #90