Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use inotify in sreview-detect #48

Open
yoe opened this issue Oct 31, 2017 · 1 comment
Open

use inotify in sreview-detect #48

yoe opened this issue Oct 31, 2017 · 1 comment

Comments

@yoe
Copy link
Owner

yoe commented Oct 31, 2017

The detect_files script currently is expected to run from cron, and will then parse all files that pass the input glob. As more data is being generated, this becomes more and more inefficient.

A more efficient way of doing this would be to:

  • Check all files on startup and update the database with their metadata
  • Set up inotify event listeners for "someone wrote to a file and closed it then" in the correct directories
  • Wait for the inotify events to fire
  • If the inotify events fire and the name of the files match our input glob, update the database with their metadata

@krokodilerian, do you think it is worth prioritizing this for FOSDEM 2018, or should I not bother?

@krokodilerian
Copy link

I don't have data how much time it took to process the directories, but even for the size of FOSDEM I don't think it's worthy. It's a nice idea, though.

@yoe yoe changed the title use inotify in detect_files use inotify in sreview-detect Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants