Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WISH: migrate to a BIP44 derivation path #21

Open
BeardPower opened this issue Jul 10, 2018 · 2 comments
Open

WISH: migrate to a BIP44 derivation path #21

BeardPower opened this issue Jul 10, 2018 · 2 comments

Comments

@BeardPower
Copy link
Contributor

BeardPower commented Jul 10, 2018 •
edited
Loading

The old Ledger apps, including the Red wallet, use a legacy derivation path of m/purpose'/coin_type'/account'/address_index, but the new Ledger Live app uses the BIP44 derivation path of m/purpose'/coin_type'/account'/change/address_index.

So I suggest migrating the Red wallet derivation path to BIP44.
bitbegin added a commit that referenced this issue Jul 28, 2018
@bitbegin
FEAT: issue #21 (change path to BIP44)
48b10c4
bitbegin added a commit that referenced this issue Jul 28, 2018
@bitbegin
FIX: add fix to issue #21 (change path to BIP44)
b794324
@BeardPower
Copy link
Contributor Author

Will you also patch wallet.red, because it is passing an index, not the path ids like in your BIP44 derivation path?

@bitbegin
Copy link
Collaborator

i don't if necessary to use this address for master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitbegin @BeardPower