-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation of oneDNN with C++20 on Windows #2028
Comments
oneDNN should be buildable with C++ 20, so this looks like a bug. Relevant error message:
|
@rjoursler Looks like this line needs to take into account |
No, as I stated in the description:
You need to rely on _MSVC_LANG for MSVC compiler instead of __cplusplus WA on OpenVINO side is to use https://learn.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-170, but we want to avoid it. |
This should be fixed by commit ece6802, @ilya-lavrenov could you please confirm this issue is fully resolved? |
Summary
oneDNN and some software which uses it (e.g. OpenVINO), are distributed as source code.
And some users may want to compile it with their own C++ standard and compile flags.
Problem statement
oneDNN with GPU backend enabled cannot be compiled with C++ 20 with MSVC compiler.
Build logs are https://github.com/openvinotoolkit/openvino/actions/runs/10289707118/job/28478073165
Problematic place https://github.com/oneapi-src/oneDNN/blob/main/src/gpu/intel/jit/gemm/include/internal/utils.hpp#L22 - __cplusplus is defined to 1997 value for MSVC compiler.
Preferred solution
Please, enable C++20 support om compilation level.
The text was updated successfully, but these errors were encountered: