"<current()>" causes exception when Faker\Generator instance is passed to NativeLoader constructor

[martingold]

Issue

When I pass my own Faker\Generator then InvalidArgumentException: Unknown formatter "current" is thrown. My guess is that Alice does not register its current provider to the passed Generator instance.

Why

My motivation to do this is to use $locale parameter in Faker\Factory::create() to set locale as it seems to be the most intuitive way to set locale. It is a handy way instead of extending NativeLoader. But it does not work (locale is still default) but that is subject for another issue.

Reproducing issue

I have created minimal repository and you can try it yourself. The issue is demonstrated in these two classes:
MartinGold\AliceIssueRepo\Factory\DefaultFakerAliceFactory::create() and
MartinGold\AliceIssueRepo\Factory\InjectedFakerAliceFactory::create()

git clone https://github.com/martingold/alice-issue-minimal-repo.git
cd alice-issue-minimal-repo
composer install
php run.php # Everything works
php run.php --injected # Exception is thrown

My main question is what is the purpose of the NativeLoader $fakerGenerator argument purpose if it breaks the Alice itself and whether it is worth investigating this further and fixing it?

[theofidry]

Thanks for the report! I'll look it up ASAP although I must say that I need to take care of a couple of things in AliceDataFixtures and HautelookAliceBundle first when I manage to free some time (this month is quite busy).

[martingold]

I know you have a lot of work and you do not have to invest your free time/money into this issue :). What I wanted wanted to know is why there is NativeLoader $fakerGenerator argument in constructor and what is its purpose and some general direction how could i help. Thanks

[theofidry]

What I wanted wanted to know is why there is NativeLoader $fakerGenerator argument in constructor and what is its purpose and some general direction how could i help

The NativeLoader class is when you want to use Alice without the framework bridge (e.g. the Alice Symfony bundle NelmioAliceBundle) or when no framework bridge is available. I.e. it's just a helper to make the library usable without any framework.

There is a $fakerGenerator injectable in case you want to have full control on it but I would definitely recommend to extend the NativeLoader and override the createFakerFactory() method instead. But maybe injecting the faker generator is too error prone and should be deprecated...

[martingold]

My initial guess was right. The AliceProvider is not added to Faker\Generator when passing custom instance.

Not sure if the $this->fakerGenerator->addProvider(new AliceProvider()); should be implemented somewhere in NativeLoader constructor or just to mention in docs the need to add AliceProvider to passed Faker\Generator manually if you want to use <current()> provider.

Either way, I am ready PR to send with required changes. Thanks!

[theofidry]

The AliceProvider is not added to Faker\Generator when passing custom instance.

Then let's deprecate injecting a custom faker provided since it's more error prone than anything.

[ryrobbo]

@martingold I was experiencing this exact issue myself when setting a locale and using <current()>. Your suggestion of adding

$generator->addProvider(new AliceProvider());

worked a treat. Thank you!