Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for storing a list of expired packages in the meta #2280

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented May 14, 2024

This is a draft PR that I wanted to show off before proceeding further.

  • I generalized group_open_schema() into open_schema().
  • group_load() and expired_load() may be generalized too.
  • Add a config option that would remove expired packages during pkg upgrade? Or maybe pkg autoremove?
  • What will actually pass -e to the pkg repo call? Changes are required on the Poudriere side?
  • Bikeshedding? Should this be called "expired_packages" or somehow else?

@arrowd arrowd changed the title Draft: Add support for storing a list of expired packages in the meta Add support for storing a list of expired packages in the meta May 14, 2024
@arrowd arrowd marked this pull request as draft May 14, 2024 12:34
@arrowd arrowd force-pushed the expired branch 2 times, most recently from 0a28c40 to deb544d Compare May 23, 2024 05:59
@bapt
Copy link
Member

bapt commented May 29, 2024

dedpulication the _load function would be a good idea
I think by default we should only warn about expired in pkg upgrade, and try to remove via pkg autoremove, I would be nice to have a config option (and pkg upgrade argument) which will remove them in the upgrade transaction, but it can be done in a second step.
Regarding the -e yes some change would be needed on the poudriere side, we should perhaps take the opportunity so poudriere calls something in the ports tree, I need to think more about it.
as for the name, I am fine with expired_packages.

@arrowd
Copy link
Contributor Author

arrowd commented Jun 9, 2024

  • Deduplicate functions in pkg_repo_create.c
  • Write out an UCL file for expired packages along with groups

Now, how do I implement pkg_jobs_test_expired in pkg_jobs.c? The repo structure seems to be an internal knowledge for this layer, so we probably need to add another repo method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants