Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Dark/Night Mode #362

Open
4 tasks
nelsonic opened this issue Apr 25, 2023 · 1 comment
Open
4 tasks

Feat: Dark/Night Mode #362

nelsonic opened this issue Apr 25, 2023 · 1 comment
Labels
enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 25, 2023

It's probably not good for my eyes, but I usually have my screens on max brightness. 馃槑
Problem is: when we try and use the MVP in the evening the white background is insanely bright!

image

Note: people are not very imaginative with capturing what is on their mind ... 馃檭
Maybe we need to change the placeholder / prompt text in the MVP ... 馃挱

How GitHub Handles "Light" / "Dark" Mode:

GitHub has "Theme preferences": https://github.com/settings/appearance which defaults to "Light" for historical reasons:
image

You can manually select the "Dark" theme:

image

or set to "Sync with System":

image

Tailwind "Dark" Mode:

https://tailwindcss.com/docs/dark-mode

image

Todo

  • Figure out how to get Tailwind Dark Mode working for our MVP
    • Relevant config file: /assets/tailwind.config.js
  • Save the person's preference to settings.json
  • Document how we did it in https://github.com/dwyl/learn-tailwind including linking to the micro-PR in MVP

Quite like the theme switcher in: https://v1.daisyui.com/docs/add-themes
daisyui-theme-switcher
Uses https://github.com/saadeghi/theme-change made by the same chap as DaisyUI.

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished labels Apr 25, 2023
@iteles
Copy link
Member

iteles commented Apr 25, 2023

Agreed! It seems like MUCH less work to Stylebop dark mode from the ground up rather than trying to retrofit this 馃憣馃徎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Status: No status
Development

No branches or pull requests

2 participants