On BuildCheck exception MSBuild logs build failure but return true on buildResult

[maridematte]

When there is an exception or error logged by BuildCheck, MSBuild shows on the command line and logs it as Build Failed. But at the end, the bool for build success returns true, so build successful.

This seems to be caused by the logging override here:

msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs

Lines 1042 to 1043 in 7cf6609

	if (exceptionsThrownInEndBuild ||
	(_overallBuildSuccess && loggingService.HasBuildSubmissionLoggedErrors(BuildEventContext.InvalidSubmissionId)))

not being synchronized with the final build result:

msbuild/src/MSBuild/XMake.cs

Line 1627 in 7cf6609

buildManager.EndBuild();