Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision Trees Notebook doesn't classify elements right #16

Open
ariguiba opened this issue Oct 5, 2023 · 0 comments
Open

Decision Trees Notebook doesn't classify elements right #16

ariguiba opened this issue Oct 5, 2023 · 0 comments

Comments

@ariguiba
Copy link
Collaborator

ariguiba commented Oct 5, 2023

The notebook explaining decision trees, found under here doesn't work properly:

  • The tree partly wrong classifies some instances. Exp: with the default setting all features set to minimum value, the wine is classified as bad, although it should be good.
  • At the bottom nodes, the tree contains two leafs with the same label (good), although all the instances that lead to a good wine, should be summarized together and the tree can stop at a level prior. (The reasons behind this are probably found in the implementation of the DecisionTree in the MLJ package and should be examined there)
  • When the tree contains too many nodes, the text is unreadable anymore. some kind of wrap text or a similar approach should be implemented but CairoMakie doesn't offer this in graphs yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant